feat: Added histograms for ctag fixed WP SF #100
Conversation
There was a problem hiding this comment.
Hi @adeiorio thank you very much for your PR and I have some question.
The changes looks all good to me.
As you see the lining is failed, can you please run black in your local repo and recommit again? we are using version 24.8.0
| if "WcM" in self.selMod or "semittM" in self.selMod: | ||
| triggers = ["IsoMu27", "IsoMu24"] | ||
| isMu = True | ||
| dxySigcut = 1.0 | ||
| muNeEmSum = 0.7 | ||
| muonpTratioCut = 0.4 | ||
| isolepdz, isolepdxy, isolepsip3d = 0.01, 0.002, 2 | ||
| ### remove muNeEmSum for cutbased | ||
| if "cutbased_WcM" == self.selMod: | ||
| muNeEmSum = 1.0 | ||
| muonpTratioCut = 0.6 |
There was a problem hiding this comment.
@mondalspandan can we sync the selection?
@adeiorio we see a problem with higher pT threshold (was 0.75 before for shape, and we observed some issue. Do you observed good data/MC agreement?
There was a problem hiding this comment.
In 2022 I didn't see any particular problem in the data MC agreement. I still have to check for 2023.
There was a problem hiding this comment.
IIRC the issue was with the muNeEmSum cut not being well calibrated. It kills off a lot of DY but can introduce an additional norm change. I am happy to remove this cut.
There was a problem hiding this comment.
Hi @adeiorio @mondalspandan thanks, so both energy fraction cut should in sync?
Then which one we should take?
There was a problem hiding this comment.
Let's keep muNeEmSum = 1.0 since it's the safest.
There was a problem hiding this comment.
How about muonpTratioCut ? @mondalspandan
There was a problem hiding this comment.
So we should leave muonpTratioCut = 0.4 and muNeEmSum = 1.0 @mondalspandan @adeiorio are you agree on this?
There was a problem hiding this comment.
This looks ok to me, I think we should merge this
@adeiorio @mondalspandan what do you think?
There was a problem hiding this comment.
It's of course ok with me :)
Ming-Yan
changed the title
* Added histograms for ctag fixed WP SF * restoring plotutils * Adding CI for fixed WP workflow * uniform requirement for shape and fixed WP analyses * new hist only for cutbased wf * fixing pipeline --------- Co-authored-by: Agostino De Iorio <agostino.de.iorio@cern.ch>
util: add WP hist
wf: add WP hists & selections