Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to handle Warp Connector #26

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Added code to handle Warp Connector #26

merged 3 commits into from
Aug 5, 2024

Conversation

vinothsubramanian
Copy link
Contributor

Though WARP Connector is still in beta, the connection works perfectly when connected to a team.

I have updated entrypoint.sh to skip warp-cli registration if mdm.xml is present

Signed-off-by: Ramasubramanian M <vinothsubramanian@gmail.com>
@cmj2002
Copy link
Owner

cmj2002 commented Aug 4, 2024

  1. The [Note] should be [!NOTE] so that it can be displayed as a alert (or callout).
  2. You are using prettier or something similar, which changed my ordered list in build instructions. This should be revert.
  3. If the mdm file presents, the lisence key should not be registered.
  4. Is the --accept-tos necessary? I have done it when starting daemon in line 19.

Signed-off-by: Ramasubramanian M <vinothsubramanian@gmail.com>
Signed-off-by: Ramasubramanian M <vinothsubramanian@gmail.com>
@vinothsubramanian
Copy link
Contributor Author

@cmj2002 I have fixed the comments. Kindly see below:

  1. Fixed

  2. Since it was appearing as continuous numbers I updated it. Now I understood that we need indentation. I have added extra space to take care of it

    Before Change
    image

    After Change
    image

  3. Since I don't have active WARP+ I couldn't check it. Moved license key registration inside if block.

  4. Without --accept-tos flag the container fails to start with mdm.xml in place

warp-socks  | Please accept the WARP Terms of Service by running this command in a TTY or by passing the --accept-tos flag.
warp-socks  | 2024-08-05T04:04:57.027Z  INFO warp::warp_service::ipc_loop: IPC connection ended
warp-socks exited with code 0

@cmj2002 cmj2002 merged commit 9ee31cb into cmj2002:main Aug 5, 2024
@cmj2002
Copy link
Owner

cmj2002 commented Aug 5, 2024

Thanks for the PR!

@cmj2002
Copy link
Owner

cmj2002 commented Aug 5, 2024

Docker hub image updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants