Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Coordinates by Location Name endpoint #189

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jan 18, 2024

  1. Add the PSR-18 adapter for Guzzle 6

    This package is required, largely for testing, so that Guzzle requests
    can be mocked instead of making live calls to the API.
    settermjd committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9df25fb View commit details
    Browse the repository at this point in the history
  2. Implement the Get Coordinates by Location Name API endpoint

    This is a simplistic implementation of the endpoint. It's not complete,
    yet, but it's a start. Its implementation is required to implement the
    one call API endpoint.
    settermjd committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ee7aad0 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Fix up an incorrect refactoring of Location

    I didn't look deeply enough at Location previously to realise that City
    already extended it. Given that, this change effectively reverts the
    previous refactor of Location to put the changes where they should be,
    on City.
    settermjd committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    804ef25 View commit details
    Browse the repository at this point in the history
  2. Add more test coverage of buildCoordinatesByLocationNameUrl

    As the method's private, it can't be tested directly. However, that's
    not to say that it cannot be tested. So this test does that to ensure
    that the URL it returns is always correct.
    settermjd committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    3a0a331 View commit details
    Browse the repository at this point in the history