Setup Angular Rails XSS Escaping #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksylvest
force-pushed
the
initial-setup
branch
3 times, most recently
from
d8eca19 to
de103b2
Compare
|
@claudioclutter for review - integration with specs is here: https://github.com/clutter/clutter-platform/pull/3570 |
ksylvest
force-pushed
the
initial-setup
branch
2 times, most recently
from
aa79c88 to
f9e9862
Compare
spec/angular_rails_xss_spec.rb
Outdated
| expect(escaped).to eql('{{"\\{\\{"{{"\\}\\}"}}2+3{{"\\}\\}"}}') | ||
| end | ||
|
|
||
| it 'also does the normal CG.escapeHTML to work with other escapes' do |
There was a problem hiding this comment.
@ksylvest Minor typo: CG vs CGI
There was a problem hiding this comment.
Thanks - I also hate the new Macbook keyboard...
|
@claudioclutter sorry - I realized I assigned this a bit early. The XSS replacement had a bug with quote escaping - so opted to go with a $root variable and define it. This fixup has the changes: a717f91 |
claudioclutter
approved these changes
Apr 20, 2018
This library patches CGI.escapeHTML to replace {{ and }} with escaped versions. The reason for doing this is user generated input (i.e. form submissions, active record interpolation, etc.) can easily be spoofed to contain Angular interoperable blocks “{{2 + 3}}”. The style of injection might lead to XSS attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library patches CGI.escapeHTML to replace {{ and }} with escaped versions. The reason for doing this is user generated input (i.e. form submissions, active record interpolation, etc.) can easily be spoofed to contain Angular interoperable blocks “{{2 + 3}}”. The style of injection might lead to XSS attacks.