Support for kerberization #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaspivak
reviewed
Mar 14, 2019
kerberos_helper.py
Outdated
|
|
||
| class Kerberos_Helper: | ||
|
|
||
| def __init__(self, network, operating_system): |
There was a problem hiding this comment.
Can we add a docstring to the class reflecting this init? Also, since it looks like operating_system is a version and not the whole OS name, can we update the naming to make that clear?
dimaspivak
requested changes
Mar 14, 2019
start.py
Outdated
| nodes = [primary_node] + secondary_nodes | ||
| if args.kerberos: | ||
| logger.info('Creating KDC node...') | ||
| kdc = kerberos_helper.Kerberos_Helper(args.network, args.operating_system) |
There was a problem hiding this comment.
Any reason not to call the class Kdc in the first place if it'll be instantiated and treated like one?
There was a problem hiding this comment.
Changed the instance variable name.
There was a problem hiding this comment.
Just tiny suggestions. Can we update the README to give an example of using the new args?
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.