- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
Support for installation from a branch of StreamSets Data Collector #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for installation from a branch of StreamSets Data Collector #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointed Kirti to potentially overhaul how we deal with the SDC parcel (to use a local repo instead of the method I wrote originally). Stay tuned...
7513ffc    to
    a0d975f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny nits and this is ready to go!
        
          
                images/sdc/Dockerfile
              
                Outdated
          
        
      |  | ||
| # See http://community.cloudera.com/t5/Cloudera-Manager-Installation/Stop-CM-undistributing-my-parcel/m-p/61402. | ||
| RUN touch "${PARCEL_DIRECTORY}/.dont_delete" | ||
| RUN touch "${PARCEL_REPO_DIRECTORY}/.dont_delete" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this (but should do a quick test to be sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                topology.yaml
              
                Outdated
          
        
      | --sdc-build: | ||
| help: If specified, the build from which to install StreamSets Data Collector (e.g. of the form "2038" "3.1.0.0" "latest") | ||
| metavar: ver | ||
| --sdc-S3-bucket: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--sdc-s3-bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
        
          
                start.py
              
                Outdated
          
        
      |  | ||
|  | ||
| def _get(url): | ||
| response = requests.Session().get(url) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for Session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                start.py
              
                Outdated
          
        
      | 'chown cloudera-scm:cloudera-scm /opt/cloudera/csd/STREAMSETS*.jar', | ||
| 'chmod 644 /opt/cloudera/csd/STREAMSETS*.jar', | ||
| 'chown cloudera-scm:cloudera-scm /opt/cloudera/parcel-repo/STREAMSETS_*'] | ||
| primary_node.execute('; '.join(commands)) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might wanna join with && to make sure failing commands kill it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
a0d975f    to
    ab5eef0      
    Compare
  
    | lgtm +2 | 
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
…lusterdock#21) * Support for installation from a branch of StreamSets Data Collector * Install StreamSets DataCollector parcel using a local parcel repository * Work on review comments, make arguments same across topology.yaml and build_images script * Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
This allows to specify sdc_build and sdc_S3_bucket. Using these two parameters, clusterdock pulls the correct version of SDC and installs it.