Skip to content

Conversation

@kirtiv1
Copy link
Contributor

@kirtiv1 kirtiv1 commented Mar 26, 2018

This allows to specify sdc_build and sdc_S3_bucket. Using these two parameters, clusterdock pulls the correct version of SDC and installs it.

@kirtiv1 kirtiv1 requested a review from dimaspivak March 26, 2018 21:29
Copy link
Member

@dimaspivak dimaspivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed Kirti to potentially overhaul how we deal with the SDC parcel (to use a local repo instead of the method I wrote originally). Stay tuned...

@kirtiv1 kirtiv1 force-pushed the sdc_install_from_branch branch from 7513ffc to a0d975f Compare March 29, 2018 22:38
Copy link
Member

@dimaspivak dimaspivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny nits and this is ready to go!


# See http://community.cloudera.com/t5/Cloudera-Manager-Installation/Stop-CM-undistributing-my-parcel/m-p/61402.
RUN touch "${PARCEL_DIRECTORY}/.dont_delete"
RUN touch "${PARCEL_REPO_DIRECTORY}/.dont_delete"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this (but should do a quick test to be sure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

topology.yaml Outdated
--sdc-build:
help: If specified, the build from which to install StreamSets Data Collector (e.g. of the form "2038" "3.1.0.0" "latest")
metavar: ver
--sdc-S3-bucket:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sdc-s3-bucket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

start.py Outdated


def _get(url):
response = requests.Session().get(url)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for Session

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

start.py Outdated
'chown cloudera-scm:cloudera-scm /opt/cloudera/csd/STREAMSETS*.jar',
'chmod 644 /opt/cloudera/csd/STREAMSETS*.jar',
'chown cloudera-scm:cloudera-scm /opt/cloudera/parcel-repo/STREAMSETS_*']
primary_node.execute('; '.join(commands))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might wanna join with && to make sure failing commands kill it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kirtiv1 kirtiv1 force-pushed the sdc_install_from_branch branch from a0d975f to ab5eef0 Compare April 2, 2018 23:22
@kirtiv1 kirtiv1 requested a review from srids April 5, 2018 17:00
@srids
Copy link

srids commented Apr 10, 2018

lgtm +2

@kirtiv1 kirtiv1 merged commit d5daef3 into clusterdock:streamsets Apr 10, 2018
@kirtiv1 kirtiv1 deleted the sdc_install_from_branch branch April 10, 2018 20:15
dimaspivak pushed a commit that referenced this pull request May 4, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
dimaspivak pushed a commit that referenced this pull request May 8, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request May 15, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request May 18, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
dimaspivak pushed a commit that referenced this pull request May 21, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request May 22, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
dimaspivak pushed a commit that referenced this pull request May 22, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 7, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 14, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 14, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 15, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 20, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 20, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 20, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Jun 20, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Jun 20, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Jun 21, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 21, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Jun 22, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
dimaspivak pushed a commit that referenced this pull request Jul 6, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Jul 24, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Aug 23, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Aug 31, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Sep 12, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Sep 21, 2018
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Oct 5, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Oct 26, 2018
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Feb 16, 2019
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Mar 19, 2019
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit that referenced this pull request Apr 10, 2019
)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 6, 2019
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
kirtiv1 added a commit to kirtiv1/topology_cdh that referenced this pull request Jun 11, 2019
…lusterdock#21)

* Support for installation from a branch of StreamSets Data Collector

* Install StreamSets DataCollector parcel using a local parcel repository

* Work on review comments, make arguments same across topology.yaml and build_images script

* Remove arguments sdc-build, sdc-s3-bucket etc. and just keep sdc-version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants