Lazy Streaming Client #82
Conversation
This is in preparation of creating a FactoryLazyStreamingClientTest for the new LazyStreamingClient
There was a problem hiding this comment.
@WyriHaximus Thanks for looking into this, but it looks like this changeset might be incomplete, can you take a look at this? 👍
|
@clue yeah working on that, hence the WIP in the title 😋 , was about the commit the |
|
@clue this PR is ready for review |
There was a problem hiding this comment.
@WyriHaximus Thank you very much for this update! I will review this more thoroughly as soon as time permits.
Before getting this in, I would like to finish support for connection cancellation and timeout support. Your suggested changes make perfect sense in combination with this and I will report back with an update to take advantage of this with your changes combined 👍
|
@clue cool keep me updated. Do you at some point also want to include a TTL for the connection where it will disconnect after a certain amount of time without activity? (Thinking ahead) |
|
@clue I'll update this PR later today 👍 |
|
@WyriHaximus Just a quick progress update: I've picked this one up earlier this week and have worked out most of the outstanding issues already (including reconnection, idle timeouts and handling pubsub subscriptions). I'll finish this asap because I plan to start using this in a live project no later than next week |
|
@clue ok cool, do you still want me to update this or should we close it instead then? |
|
@WyriHaximus If you feel an update provides any value, I welcome any contribution 👍 Other than that, I'd really want to avoid wasting anybody's work due to duplicate efforts. I'm currently planning to squash your changes to a single commit in a new PR and give proper credit for your initial work 👍 |
|
@clue that works for me 👍 |
Originally filed in clue#82 by @WyriHaximus
|
See #87 |
Awesome |
Implements / Closes #80