Check if the function is declared before declaring it.#39
Merged
clue merged 1 commit intoclue:masterfrom Mar 27, 2019
NikoGrano:patch-1
Merged
Check if the function is declared before declaring it.#39clue merged 1 commit intoclue:masterfrom NikoGrano:patch-1
clue merged 1 commit intoclue:masterfrom
NikoGrano:patch-1
Conversation
Contributor
Author
|
Related clue/stream-filter#23 |
Contributor
Author
|
Just a bumb. This PR has been also updated 🙃 |
Contributor
Author
|
Status? |
Owner
|
@Niko9911 Changes LGTM, can you squash this into a single commit like in reactphp/promise-timer#36? |
clue
added
bug
Contributor
Author
|
Made requested changes. Thank you. This can be merged now. @clue 🎖️ |
Owner
|
Thanks for the quick update, now let's get this in! |
Contributor
Author
|
@clue Don't want be pinging all time, but could this be tagged? |
Contributor
Author
|
@clue Can you tag this as 1.3.1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case you use pthreads or something else related to threading you might encounter this issue. It happens only with functions and is fixable only by adding these checks. Another way to avoid this is to wrap functions as static into classes.