[WIP] Implement Blocking lists. #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIX: do not exit the event loop prematurely.
* Upgrade promises and evenement.
* Add new Type\RedisList class (adds unshift and pop events
to SplDoublyLinkedList).
* Pass the loop to Business\Lists (for use by Clue\React\Block).
* Return Type\RedisList from Storage for lists.
…ecial type. This fixes a problem when multiple clients block on the same list.
…e active, pass just the key to blockers and wake them up once the length has been retrieved.
…ynchronously write the response when a promise is returned.
|
@pwhelan Thanks for your work, I really like the progress you're making here! I'll mark this as WIP for now and will keep an eye on this. Make sure to send me a ping and/or remove the WIP marker if you have any questions or feel this needs a review 👍 |
|
Yeah. I've had to repeatedly rethink the approach behind it. It seems to be good enough now to run the unit tests for one of my projects. I also have a hashes branch based off of this one. |
|
@clue the one last remaining bit to fix is with the timeouts. I was thinking of somehow exposing the timeout value to the Invoker, thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finished the blocking lists implementation. In the process I had to upgrade and add the following packages:
I created a wrapper class for SplDoublyLinkedList with the EventEmitterTrait. That should make how I implementated it pretty obvious.