Skip to content

59 change context type for v2 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Apr 6, 2023
Merged

Conversation

tcnichol
Copy link
Contributor

The change is that context is now the same as v1, a list that can contain a URL or a dictionary. This works when the context is defined in extractor_info.json and works when it is dynamically generated by the extractor (such as extractors-core filedigest.)

Works with this pull request for clowder2:

clowder-framework/clowder2#328

at different points in the code, the version will be checked
different methods will use different endpoints and will use the bearer token instead of the key
problem - the method in the extractor is not getting the secret key
possible fix - use token for secret key
need to add extractor info
more to be added later for datasets once that completed in clowderv2
…o make sure future metadata that matches is not reprocessed)
some routes not implemented in v2 clowder, left for later
@tcnichol tcnichol linked an issue Feb 15, 2023 that may be closed by this pull request
@tcnichol tcnichol self-assigned this Feb 15, 2023
@tcnichol tcnichol added the enhancement New feature or request label Feb 15, 2023
@ddey2 ddey2 self-requested a review February 21, 2023 20:33
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please resolve merge conflicts.

@tcnichol tcnichol linked an issue Feb 22, 2023 that may be closed by this pull request
@max-zilla max-zilla merged commit 1b4ce96 into master Apr 6, 2023
@max-zilla max-zilla deleted the 59-change-context-type-for-v2 branch July 20, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

change context type for v2 pyclowder - add missing methods
4 participants