-
Notifications
You must be signed in to change notification settings - Fork 2
59 change context type for v2 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at different points in the code, the version will be checked different methods will use different endpoints and will use the bearer token instead of the key
problem - the method in the extractor is not getting the secret key possible fix - use token for secret key
need to add extractor info
more to be added later for datasets once that completed in clowderv2
…o make sure future metadata that matches is not reprocessed)
some routes not implemented in v2 clowder, left for later
…points have to change, as the headers
used in filedigest
should fix build errors
This was referenced Feb 16, 2023
ddey2
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Please resolve merge conflicts.
ddey2
approved these changes
Mar 2, 2023
max-zilla
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is that context is now the same as v1, a list that can contain a URL or a dictionary. This works when the context is defined in extractor_info.json and works when it is dynamically generated by the extractor (such as extractors-core filedigest.)
Works with this pull request for clowder2:
clowder-framework/clowder2#328