chore(volo-http): add TimeoutLayer and FailOnStatus layer #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the previous `MetaService` was too coupled with the client configuration, it was very inelegant. So we removed `MetaService` and used `TimeoutLayer` and `FailOnStatus` layers to replace the previous `MetaService` with the two configs. BREAK CHANGES: - `ClientBuilder::fail_on_status` has been removed, users should use `FailOnStatus` layer instead - `ClientBuilder::set_request_timeout` has been removed, users should use `TimeoutLayer` instead TODO: - Refactor `Target`, `CallOpt` and `Config` - Support setting timeout at request level Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
yukiiiteru
force-pushed
the
chore/remove-meta-service
branch
from
8679515
to
21ef067
Compare
PureWhiteWu
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous
MetaServicewas too coupled with the client configuration, it was very inelegant.Solution
Remove
MetaServiceand usedTimeoutLayerandFailOnStatuslayers to replace the previousMetaServicewith the two configs.Break changes
ClientBuilder::fail_on_statushas been removed, users should useFailOnStatuslayer insteadClientBuilder::set_request_timeouthas been removed, users should useTimeoutLayerinsteadConsidering that Volo-HTTP is in rc version, there may be other break changes here later before we release a stable version.
TODO
Target,CallOptandConfig