Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(volo-http): optimize user experience #483

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

yukiiiteru
Copy link
Member

Motivation

  • logs from volo-http are confusing
  • timeout cannot removed
  • type of client with layers are complex

Solution

  • unified log format in volo-http with prefix [Volo-HTTP]
  • adjusted the timeout interface, Dutation -> Option<Duration>
  • add generic types for DefaultClient

This commit unified log format in `volo-http`, adjusted the timeout
interface and add generic types for `DefaultClient`.

Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
@yukiiiteru yukiiiteru requested review from a team as code owners August 8, 2024 09:30
@yukiiiteru yukiiiteru merged commit fe68dcd into cloudwego:main Aug 9, 2024
15 checks passed
@yukiiiteru yukiiiteru deleted the chore/opt branch August 9, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants