fix(pilota-thrift-parser): compatible with separators after syntax item blocks in idl #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item blocks in idl
Ggiggle
force-pushed
the
fix/idl_parser
branch
from
856fe48
to
3080491
Compare
PureWhiteWu
previously approved these changes
Nov 5, 2024
PureWhiteWu
approved these changes
Nov 5, 2024
Millione
approved these changes
Nov 5, 2024
|
One more note on this - in case pilota fails to parse IDL, volo creates empty volo.yml in current directory and for next run its required to delete this file. I know this is not an often oteration, but still a bit confusing. |
|
Thanks for this feedback, could you please create an issue for this and we will optimize this in the future. |
|
sure! cloudwego/volo#523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Referred to idl parser issue, the separator character ';' or ',' after syntax item blocks such as struct, enum, service, or typedef are not allowed, even thought this syntax is not stated in the idl rfc, there are some implement lib, such as thrift and thriftpy2, supporting this feature.
Solution
We will be compatible with this writing method and allow the use of "," or ";" delimiters after various syntax blocks, including struct, enum, typedef, service and const value.