Skip to content

docs: update CONTRIBUTING.md to change PR base branch to main #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppzqh merged 2 commits into from
Jun 16, 2025
Merged

docs: update CONTRIBUTING.md to change PR base branch to main #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf05c5d
docs: update CONTRIBUTING.md to change PR base branch to main
ppzqh Jun 16, 2025
37d6f7d
chore: style guide
ppzqh Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
3. [Fork](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo) the cloudwego/netpoll repo.
4. In your forked repository, make your changes in a new git branch:
```
git checkout -b my-fix-branch develop
git checkout -b my-fix-branch main
```
5. Create your patch, including appropriate test cases.
6. Follow our [Style Guides](#code-style-guides).
Expand All @@ -41,7 +41,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
```
git push origin my-fix-branch
```
9. In GitHub, send a pull request to `netpoll:develop`
9. In GitHub, send a pull request to `netpoll:main`

## Contribution Prerequisites
- Our development environment keeps up with [Go Official](https://golang.org/project/).
Expand All @@ -50,9 +50,5 @@ Before you submit your Pull Request (PR) consider the following guidelines:
- Maybe you need familiar with [Actions](https://github.com/features/actions)(our default workflow tool).

## Code Style Guides
Also see [Pingcap General advice](https://pingcap.github.io/style-guide/general.html).

Good resources:
- [Effective Go](https://golang.org/doc/effective_go)
- [Go Code Review Comments](https://github.com/golang/go/wiki/CodeReviewComments)
- [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md)