Skip to content

fix: fd operator read race after inuse called #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joway merged 1 commit into from
Jul 24, 2024
Merged

fix: fd operator read race after inuse called #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion poll_default_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,12 @@ func (p *defaultPoll) Trigger() error {

// Control implements Poll.
func (p *defaultPoll) Control(operator *FDOperator, event PollEvent) error {
// DON'T move `fd=operator.FD` behind inuse() call, we can only access operator before op.inuse() for avoid race
// G1: G2:
// op.inuse() op.unused()
// op.FD -- T1 op.FD = 0 -- T2
// T1 and T2 may happen together
var fd = operator.FD
var op int
var evt epollevent
p.setOperator(unsafe.Pointer(&evt.data), operator)
Expand All @@ -256,5 +262,5 @@ func (p *defaultPoll) Control(operator *FDOperator, event PollEvent) error {
case PollRW2R: // connection wait read
op, evt.events = syscall.EPOLL_CTL_MOD, syscall.EPOLLIN|syscall.EPOLLRDHUP|syscall.EPOLLERR
}
return EpollCtl(p.fd, op, operator.FD, &evt)
return EpollCtl(p.fd, op, fd, &evt)
}