perf: nocopy read for ReadString and ReadBinary API if possible #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joway
force-pushed
the
perf/nocopy-read
branch
5 times, most recently
from
3f1e6d0 to
267a8c5
Compare
joway
commented
Mar 4, 2024
ppzqh
reviewed
Apr 18, 2024
ppzqh
reviewed
Apr 18, 2024
ppzqh
previously approved these changes
Apr 19, 2024
joway
force-pushed
the
perf/nocopy-read
branch
2 times, most recently
from
ccbc365 to
2de2406
Compare
jayantxie
previously approved these changes
Apr 22, 2024
jayantxie
approved these changes
Apr 23, 2024
ppzqh
approved these changes
Apr 23, 2024
kingcanfish
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
perf
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
before:
after:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: