fix(grpc): fix framer in loopyWriter for flush in time #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joway
previously approved these changes
Apr 15, 2022
SinnerA
force-pushed
the
fix/fix_framer_rw_without_nhttp2
branch
2 times, most recently
from
84fbb14 to
e3b11ec
Compare
joway
previously approved these changes
Apr 18, 2022
lsjbd
reviewed
Apr 18, 2022
SinnerA
force-pushed
the
fix/fix_framer_rw_without_nhttp2
branch
from
56354c0 to
661e66b
Compare
SinnerA
changed the title
lsjbd
approved these changes
Apr 20, 2022
YangruiEmma
approved these changes
Apr 20, 2022
SinnerA
changed the title
YangruiEmma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it (English/Chinese):
zh:
修复 http2 framer 的读写逻辑，例如避免对端无法及时收到 framer
下面是带来的副作用：
en:
Fix the sending and receiving logic about http2 framer, such as preventing the peer unable receive framer in time
Bring some side effects:
Which issue(s) this PR fixes: