[WIP] feat(streaming): extend streaming trace event and gRPC/ttstream supports more detailed event reporting #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
11 times, most recently
from
411f51c to
76ad6fb
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
===========================================
+ Coverage 49.97% 61.24% +11.27%
===========================================
Files 321 387 +66
Lines 26774 34833 +8059
===========================================
+ Hits 13379 21333 +7954
- Misses 12095 12216 +121
+ Partials 1300 1284 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
4 times, most recently
from
03f8bb5 to
7fd571b
Compare
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
3 times, most recently
from
6d38036 to
bb16fca
Compare
DMwangnima
changed the title
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
5 times, most recently
from
3fce366 to
e2e9bd1
Compare
jayantxie
reviewed
Sep 1, 2025
| // we need to execute handleCtx synchronously to ensure that | ||
| // after the handleStream callback completes (i.e., when this Stream becomes visible at the gRPC layer), | ||
| // tracing-related information such as spans contained within ctx can be directly utilized. | ||
| rCtx, ri, serviceName, methodName, ok := t.handleCtx(svrTrans, s) |
There was a problem hiding this comment.
直接拿个新的原子变量，在ctx初始化完成后，set到stream.eventCtx这样的字段里就可以了，不用拆分函数
ppzqh
reviewed
Sep 1, 2025
| cd .. | ||
| rm -rf kitex-tests | ||
| git clone --depth=1 https://github.com/cloudwego/kitex-tests.git | ||
| git clone -b test/streaming_trace --depth=1 https://github.com/DMwangnima/kitex-tests.git |
ppzqh
reviewed
Sep 1, 2025
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
from
e2e9bd1 to
9714b26
Compare
DMwangnima
force-pushed
the
feat/stream_trace_event
branch
from
9714b26 to
40c6121
Compare
DMwangnima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: