Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correct the function signature of the rpcinfo.TimeoutProvider implementation #1038

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Jul 25, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@whalecold whalecold requested review from a team as code owners July 25, 2023 10:21
@whalecold whalecold changed the title fix(config): correct the function signature of the rpcinfo.TimeoutPro… fix(config): correct the function signature of the rpcinfo.TimeoutProvider implementation Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (b26b928) 67.91% compared to head (63f5340) 67.88%.

❗ Current head 63f5340 differs from pull request most recent head d534906. Consider uploading reports for the commit d534906 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1038      +/-   ##
===========================================
- Coverage    67.91%   67.88%   -0.03%     
===========================================
  Files          249      249              
  Lines        18900    18900              
===========================================
- Hits         12835    12830       -5     
- Misses        4891     4896       +5     
  Partials      1174     1174              
Files Changed Coverage Δ
pkg/rpctimeout/item_rpc_timeout.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 merged commit 4865773 into cloudwego:develop Jul 25, 2023
15 checks passed
@whalecold whalecold deleted the fix/config branch September 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants