fix(client): fix oneway seqid and lower loss rate

cloudwego · Feb 25, 2022 · 11aeaaa · 11aeaaa
1 parent da52b2c
commit 11aeaaa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/remote/codec/util.go b/pkg/remote/codec/util.go
@@ -63,7 +63,7 @@ func SetOrCheckMethodName(methodName string, message remote.Message) error {
 // SetOrCheckSeqID is used to check the sequence ID.
 func SetOrCheckSeqID(seqID int32, message remote.Message) error {
 	switch message.MessageType() {
-	case remote.Call:
+	case remote.Call, remote.Oneway:
 		if ink, ok := message.RPCInfo().Invocation().(rpcinfo.InvocationSetter); ok {
 			ink.SetSeqID(seqID)
 		} else {

diff --git a/pkg/remote/remotecli/client.go b/pkg/remote/remotecli/client.go
@@ -21,6 +21,7 @@ import (
 	"errors"
 	"net"
 	"sync"
+	"time"
 
 	"github.com/cloudwego/kitex/pkg/kerrors"
 	"github.com/cloudwego/kitex/pkg/remote"
@@ -98,6 +99,10 @@ func (c *client) Recv(ctx context.Context, ri rpcinfo.RPCInfo, resp remote.Messa
 	if resp != nil {
 		err = c.transHdlr.Read(ctx, c.conn, resp)
 		c.transHdlr.OnMessage(ctx, nil, resp)
+	} else {
+		// Wait for the request to be flushed out before closing the connection.
+		// 500us is an acceptable duration to keep a minimal loss rate at best effort.
+		time.Sleep(time.Millisecond / 2)
 	}
 
 	c.connManager.ReleaseConn(err, ri)