Skip to content

Conversation

zchee
Copy link

@zchee zchee commented Apr 16, 2024

What type of PR is this?

fix: A bug fix

What this PR does / why we need it (en: English/zh: Chinese):

en: Fix check proto3 syntax logic to use continue instead of return nil
zh:

Which issue(s) this PR fixes:

Nothing.

@zchee zchee requested review from a team as code owners April 16, 2024 20:50
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

go.mod Outdated
require (
github.com/gogo/protobuf v1.3.2
google.golang.org/protobuf v1.28.0
google.golang.org/protobuf v1.33.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for this bugfix to update the protobuf version?

// check: only support proto3 now
for _, f := range gen.Files {
// check: only support proto3 now
if f.Desc.Syntax() != protoreflect.Proto3 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an example to reproduce this issue.

zchee added 2 commits August 20, 2024 08:28
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants