Adding two new values to OperatingSystem attributes #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sir-sigurd
reviewed
Jul 9, 2024
troposphere/validators/ssm.py
Outdated
| @@ -97,6 +97,8 @@ def operating_system(os): | |||
| valid_os = [ | |||
| "AMAZON_LINUX", | |||
| "AMAZON_LINUX_2", | |||
| "AMAZON_LINUX_2022", | |||
| "AMAZON_LINUX_2003", | |||
There was a problem hiding this comment.
Suggested change
| "AMAZON_LINUX_2003", | |
| "AMAZON_LINUX_2023", |
sir-sigurd
reviewed
Jul 9, 2024
| @@ -97,6 +97,8 @@ def operating_system(os): | |||
| valid_os = [ | |||
| "AMAZON_LINUX", | |||
There was a problem hiding this comment.
Might make sense to add missing ALMA_LINUX as well
Suggested change
| "AMAZON_LINUX", | |
| "ALMA_LINUX", | |
| "AMAZON_LINUX", |
Add ALMA_LINUX, AMAZON_LINUX_2022, and AMAZON_LINUX_2023
|
Thanks @trustedtwin-github and @sir-sigurd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatingSystem accept AMAZON_LINUX_2023 and AMAZON_LINUX_2022
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ssm-patchbaseline.html#cfn-ssm-patchbaseline-operatingsystem