Fixes and updates from spec version 119.1.0 to 134.0.0 #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most properties have a Properties dictionary but there seems to be a usage where a property entry just denotes a type specification. In the past this was worked around by lifting the type information into the right place. This change attempts to automate this process.
|
I will test this today or tomorrow and get back with you on my results. Thanks a ton! |
|
@tnielsen2 thank you for taking a look at the changes. I just rebased and merged into main so going against main would be best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and updates from spec version 119.1.0 to 134.0.0.
This set of changes intentionally omits Connect::EvaluationForm due to recursion issues and will look to add that support in the future.
@tnielsen2 can you do a quick check on this branch and then I can commit it into main?