Mark constants as final #2126
Merged
Mark constants as final #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-k
force-pushed
the
final-constants
branch
from
4fafd27
to
fb62e2d
Compare
|
Apologies @michael-k as merge of #2124 caused conflicts in constants.py. I'm hoping it is a quick edit to get it fixed up again. |
michael-k
force-pushed
the
final-constants
branch
from
fb62e2d
to
36329f4
Compare
|
No worries. I need to fix some type errors anyway. |
michael-k
force-pushed
the
final-constants
branch
from
36329f4
to
5112353
Compare
michael-k
force-pushed
the
final-constants
branch
from
5112353
to
aedd74c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy (don't know about pyright) treats
Delete = "Delete"asDelete: str = "Delete"for backwards compatibility, see https://mypy.readthedocs.io/en/stable/literal_types.html#declaring-literal-variables.Delete: Final = "Delete"is the same asDelete: Literal["Delete"] = "Delete".