mypy errors starting with release 3.2.0 #2003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting with release version
3.2.0
we began gettingmypy
errors that did not used to exist when using version3.1.1
.Details
As part of the commit that introduced the new
PropsDictType
variable, thetroposphere/py.typed
file was also added. In accordance with PEP 561, the presence of this file should be used when the underlying code has types or stubs defined. The example below demonstrates how thepy.typed
can causemypy
to throw errors that did not trigger before.example.py
setup.cfg
mypy errors
Suggested Solution
Until
troposphere
fully supports typing across its codebase, I would suggest we remove thepy.typed
file.