Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit checks for black+isort #1989

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

sirrus233
Copy link
Contributor

Got bitten by this on my last PR - so figured I'd give it a little automation for the next person to come along (especially if that should happen to be me!)

Pretty simple to start, but can be expanded with additional checks down the line if desired.

@sirrus233
Copy link
Contributor Author

FWIW - pre-commit only runs against files that are changed in the commit. Since there's no source code in this PR, nothing was actually checked when I committed it. Out of curiosity, however, I ran it against the whole repo with pre-commit run -a. Looks like there are currently a handful of black violations checked in:

	modified:   docs/conf.py
	modified:   scripts/cfn
	modified:   scripts/cfn2py
	modified:   troposphere/kinesis.py

I figured the change would be easier to review if I left these alone, but if it's helpful I can add a commit with the (automated) fixes to these files.

@markpeek markpeek merged commit 14734b4 into cloudtools:main Dec 17, 2021
@markpeek
Copy link
Member

Nice! Thanks! Also, I've been meaning to update the github action to catch these as well.

@sirrus233 sirrus233 deleted the pre-commit-checks branch December 18, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants