Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkFirewall - Fixed LoggingConfiguration #1984

Merged
merged 2 commits into from
Dec 13, 2021
Merged

NetworkFirewall - Fixed LoggingConfiguration #1984

merged 2 commits into from
Dec 13, 2021

Conversation

ntwaddell
Copy link
Contributor

@ntwaddell
Copy link
Contributor Author

@markpeek

markpeek
markpeek requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this Object/Property issue. Looking at the docs LogDestinationConfig should remain singular.

troposphere/networkfirewall.py Outdated
@@ -114,17 +114,28 @@ class FirewallPolicy(AWSObject):
}


class LogDestinationConfig(AWSProperty):
class LogDestinationConfigs(AWSProperty):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs, this should remain singular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, you are correct. Updated!

troposphere/networkfirewall.py Outdated
class LoggingConfigurationProperty(AWSProperty):

props = {
"LogDestinationConfigs": ([LogDestinationConfigs], True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be use a singular inside of the list.

"LogDestinationConfigs": ([LogDestinationConfig], True)

markpeek
markpeek approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markpeek markpeek merged commit b7f2701 into cloudtools:main Dec 13, 2021
@markpeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpeek markpeek markpeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntwaddell @markpeek