-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetworkFirewall - Fixed LoggingConfiguration #1984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for correcting this Object/Property issue. Looking at the docs LogDestinationConfig
should remain singular.
troposphere/networkfirewall.py
Outdated
@@ -114,17 +114,28 @@ class FirewallPolicy(AWSObject): | |||
} | |||
|
|||
|
|||
class LogDestinationConfig(AWSProperty): | |||
class LogDestinationConfigs(AWSProperty): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs, this should remain singular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, you are correct. Updated!
troposphere/networkfirewall.py
Outdated
class LoggingConfigurationProperty(AWSProperty): | ||
|
||
props = { | ||
"LogDestinationConfigs": ([LogDestinationConfigs], True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be use a singular inside of the list.
"LogDestinationConfigs": ([LogDestinationConfig], True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
The logging configuration was not correct per CloudFormation documentation
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-networkfirewall-loggingconfiguration.html