This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Update Akka gRPC to 0.8.0 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorklang
commented
Mar 19, 2020
| val responseCodec = Codecs.negotiate(req) | ||
| val responseWriter = GrpcProtocolNative.newWriter(Codecs.negotiate(req)) | ||
| val reader = GrpcProtocolNative.newReader( | ||
| Codecs.detect(req).getOrElse(throw new IllegalArgumentException(s"Unknown codec")) |
There was a problem hiding this comment.
@raboof Did you intend to include the actual codec in the exception message?
viktorklang
commented
Mar 19, 2020
| Grpc.encodeFrame(Grpc.notCompressed, ByteString.fromArrayUnsafe(message.toByteArray)) | ||
| Source.single( | ||
| GrpcProtocolNative | ||
| .newWriter(Identity) |
There was a problem hiding this comment.
How expensive are these new methods/API?
Unfortunately running into akka/akka-grpc#628 now
To a version that has akka/akka-grpc#943 to fix compilation errors. Compile/test now works, but assembly still has problems, and the PR needs a rebase.
Reflection is provided by akka-grpc. Perhaps we'd like to make the .proto available here for some reason, but we shouldn't generate code for it.
|
This is green on travis now, depending on a published post-0.8.4 Akka gRPC snapshot. |
|
Thanks @raboof! |
25 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately running into akka/akka-grpc#628 now