Do not capitalize reserved words when used as column names #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(note does not work in CHECK constraint and generated column expressions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves the case of reserved words used as column names (eg "key", "index", "table" etc) in most places they are used:
It does not preserve the case of reserved words when used as column names in the SQL expressions used for check constraints and generated columns. This is because this tool does not have an SQL expression parser or validator and so it is impossible to distinguish between a reserved keyword in an SQL expression and a column name. The workaround here is to use backquotes to quote the column names: eg:
``key``Fixes #35