Skip to content

Conversation

@apstndb
Copy link
Collaborator

@apstndb apstndb commented Jul 9, 2024

This PR adds FLOAT32 type support.

spanner> SELECT CAST(1 AS FLOAT32), ARRAY<FLOAT32>[1];
+----------+------------+
|          |            |
+----------+------------+
| 1.000000 | [1.000000] |
+----------+------------+
1 rows in set (3.17 msecs)

fixes #175

@apstndb
Copy link
Collaborator Author

apstndb commented Jul 9, 2024

Some dependencies of new google-cloud-go (go.opentelemetry.io/otel) require the cmp and slices packages introduced in Go 1.21.

Error: ../../../go/pkg/mod/go.opentelemetry.io/otel@v1.28.0/attribute/set.go:7:2: package cmp is not in GOROOT (/opt/hostedtoolcache/go/1.19.13/x64/src/cmp)
Error: ../../../go/pkg/mod/go.opentelemetry.io/otel@v1.28.0/attribute/set.go:10:2: package slices is not in GOROOT (/opt/hostedtoolcache/go/1.19.13/x64/src/slices)

Sooner or later spanner-cli will require Go 1.21.

Copy link
Collaborator

@yfuruyama yfuruyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for quickly supporting this!

@yfuruyama yfuruyama merged commit f1ab4c9 into cloudspannerecosystem:master Jul 9, 2024
@apstndb apstndb deleted the support-float32 branch July 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support FLOAT32 type

2 participants