Conversation
Contributor
Author
|
cloudsmith-io/cloudsmith-api#85 needs to be merged to generate the api bindings before this can be rerun |
f698098 to
79b7c96
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Generic package format in upstream configurations by updating the cloudsmith-api dependency and adding "generic" to the list of supported upstream formats.
Changes:
- Updated cloudsmith-api dependency from version 2.0.22 to 2.0.24
- Added "generic" to the UPSTREAM_FORMATS list in alphabetical order
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Bumped cloudsmith-api dependency to >=2.0.24,<3.0 to enable Generic format support |
| requirements.txt | Updated pinned cloudsmith-api version to 2.0.24 |
| cloudsmith_cli/cli/commands/upstream.py | Added "generic" to UPSTREAM_FORMATS list in correct alphabetical position |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicholasmccrea
approved these changes
Jan 29, 2026
BartoszBlizniak
approved these changes
Jan 29, 2026
dkatavic
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This pull request introduces an update to the supported package formats to enable Generic uploads and upstreams. The changes ensure compatibility with newer versions of the Cloudsmith API and add support for an additional package type.
Dependency update:
cloudsmith-apidependency version from>=2.0.22,<3.0to>=2.0.24,<3.0insetup.pyto ensure compatibility with the latest API features.depends on:
Supported formats:
"generic"to the list of supported package formats incloudsmith_cli/cli/commands/upstream.py.Additional Notes
Example usage