Skip to content

Conversation

@cweilemann
Copy link
Contributor

So a few things here, @ivied -

  1. For starters, I tried renaming the root directory myself. I hope I didn't mess it up too much.

  2. I made some simple changes, mostly renaming things to American English rather than British English, and just generally making variable and function names closer to what we've used elsewhere.

  3. Also a couple small spelling issues.

As far as other features we'll need to launch.

  1. We'll need to support all of the keys in the JSON here:
{
    "token": "oppgAQO53beEIpcey3nrgA",
    "ttl": 54,
    "status": "completed",
    "url": "https://assets.cloudsight.ai/uploads/image_request/image/676/676817/676817494/data.png",
    "name": "white three seat sectional sofa with chaise",
    "nsfw": false,
    "categories": [
        "furniture"
    ],
    "similar_objects": [
        "sectional sofa"
    ],
    "structured_output": {
        "quantity": [
            "three"
        ],
        "color": [
            "white"
        ]
    }
}

So I think all that needs to be added is nsfw, categories, similar_objects, and structured_output. Hopefully this is trivial.

  1. Can we move the https://api.cloudsight.ai URL into a config file by chance? Is that a standard or is this way more standard?

  2. Is the API key secure (like how we secure the API key for CamFind)? If not, would you please make it be so that the end user doesn't have to worry about that?

  3. If it's quick, it'd look good to add some tests to the SDK. I think 1-3 above should be pretty quick. Let me know how long Fixed Interface #4 would be to do.

The client has emailed already twice today (Friday) asking when this will be ready, and they're a BIG client, so the sooner the better.

Also -- we'll want to clean up the commits of this repo before we make it public. So, essentially purge git, perform a git init again, and repush to reinitialize the commit history.

@cweilemann cweilemann requested a review from ivied June 7, 2019 20:42
@cweilemann cweilemann removed the request for review from ivied June 7, 2019 20:43
@cweilemann cweilemann removed their assignment Jun 7, 2019
Copy link
Contributor

@ivied ivied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

@ivied ivied merged commit dad5615 into master Jun 10, 2019
@cweilemann cweilemann deleted the comments branch June 11, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants