making some comments and (hopefully) small changes #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a few things here, @ivied -
For starters, I tried renaming the root directory myself. I hope I didn't mess it up too much.
I made some simple changes, mostly renaming things to American English rather than British English, and just generally making variable and function names closer to what we've used elsewhere.
Also a couple small spelling issues.
As far as other features we'll need to launch.
{ "token": "oppgAQO53beEIpcey3nrgA", "ttl": 54, "status": "completed", "url": "https://assets.cloudsight.ai/uploads/image_request/image/676/676817/676817494/data.png", "name": "white three seat sectional sofa with chaise", "nsfw": false, "categories": [ "furniture" ], "similar_objects": [ "sectional sofa" ], "structured_output": { "quantity": [ "three" ], "color": [ "white" ] } }So I think all that needs to be added is
nsfw,categories,similar_objects, andstructured_output. Hopefully this is trivial.Can we move the
https://api.cloudsight.aiURL into a config file by chance? Is that a standard or is this way more standard?Is the API key secure (like how we secure the API key for CamFind)? If not, would you please make it be so that the end user doesn't have to worry about that?
If it's quick, it'd look good to add some tests to the SDK. I think 1-3 above should be pretty quick. Let me know how long Fixed Interface #4 would be to do.
The client has emailed already twice today (Friday) asking when this will be ready, and they're a BIG client, so the sooner the better.
Also -- we'll want to clean up the commits of this repo before we make it public. So, essentially purge git, perform a
git initagain, and repush to reinitialize the commit history.