chore: Add value in RadioGroup and Tiles analytics metadata #3668
+64
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgylobko
reviewed
Jul 18, 2025
| position: string, | ||
| value: string, | ||
| disabled: boolean = false, | ||
| currentValue: string | null |
There was a problem hiding this comment.
what is the difference between value and currentValue? why do we need both?
There was a problem hiding this comment.
value is the value of the specific radio button that is being inspected. currentValue is the value currently selected for the radio group.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3668 +/- ##
========================================
Coverage 96.62% 96.62%
========================================
Files 817 817
Lines 23782 23782
Branches 8335 7912 -423
========================================
Hits 22979 22979
Misses 796 796
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgylobko
approved these changes
Jul 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Al-Dani
pushed a commit
that referenced
this pull request
Jul 21, 2025
Co-authored-by: Francesco Longo <flongo@amazon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed for page scanner
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.