Skip to content

fix: Change color for hotspot rendered inside flashbar #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

just-boris
Copy link
Member

Description

Fix color contrast issue

image

Related links, issue #, if available: n/a

How has this been tested?

Screenshot tests in my dev pipeline

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (9f97233) to head (febfd22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3567   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         807      807           
  Lines       23466    23466           
  Branches     8174     8184   +10     
=======================================
  Hits        22659    22659           
+ Misses        800      753   -47     
- Partials        7       54   +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review June 10, 2025 17:28
@just-boris just-boris requested a review from a team as a code owner June 10, 2025 17:28
@just-boris just-boris requested review from Al-Dani and removed request for a team June 10, 2025 17:28
Al-Dani
Al-Dani previously approved these changes Jun 11, 2025
<h1>Annotation Context: with Hotspots inside flashbar</h1>
<ScreenshotArea>
<AnnotationContext
currentTutorial={tutorial}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought, if this will be a screenshot test, maybe better not to launch any tutorials by default so that popover doesn't cover hotspots on other flashitems?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this. When tutorial is not active, hotspots are hidden too.

My plan for the screenshot test – dismiss the currently open popover before taking a screenshot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. need a new approval, because I needed to resolve merge conflicts with another style-dictionary change: #3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants