-
Notifications
You must be signed in to change notification settings - Fork 174
fix: Change color for hotspot rendered inside flashbar #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3567 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 807 807
Lines 23466 23466
Branches 8174 8184 +10
=======================================
Hits 22659 22659
+ Misses 800 753 -47
- Partials 7 54 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3fab8e4
to
f64789a
Compare
f64789a
to
ee590f0
Compare
<h1>Annotation Context: with Hotspots inside flashbar</h1> | ||
<ScreenshotArea> | ||
<AnnotationContext | ||
currentTutorial={tutorial} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought, if this will be a screenshot test, maybe better not to launch any tutorials by default so that popover doesn't cover hotspots on other flashitems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this. When tutorial is not active, hotspots are hidden too.
My plan for the screenshot test – dismiss the currently open popover before taking a screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. need a new approval, because I needed to resolve merge conflicts with another style-dictionary change: #3558
ee590f0
to
febfd22
Compare
Description
Fix color contrast issue
Related links, issue #, if available: n/a
How has this been tested?
Screenshot tests in my dev pipeline
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.