chore: Upgrade eslint #3509
Draft
chore: Upgrade eslint #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
force-pushed
the
upgrade-eslint
branch
from
01ea018 to
f54db28
Compare
just-boris
commented
May 14, 2025
| @@ -15,7 +15,6 @@ const data1 = [...data, thresholdSeries]; | |||
| // Position of the threshold series in a stacked chart must not affect chart's plot. | |||
| const data2 = [data[0], thresholdSeries, data[1], data[2]]; | |||
|
|
|||
| /* eslint-disable react/jsx-key */ | |||
There was a problem hiding this comment.
Eslint now prints a warning if a disable directive does nothing. Removed all useless disables
| @@ -130,7 +128,9 @@ export function DateForm({ filter, value, onChange }: PropertyFilterOperatorForm | |||
|
|
|||
| // Parse value from filter text when it changes. | |||
| useEffect(() => { | |||
| filter && setState(parseDateTimeFilter(filter.trim())); | |||
There was a problem hiding this comment.
I tuned @typescript-eslint/no-unused-expressions rule to forbid this pattern
| @@ -8,7 +8,7 @@ import AppLayoutToolbar, { AppLayoutToolbarProps } from '../../../lib/components | |||
| import createWrapper from '../../../lib/components/test-utils/dom'; | |||
| import BreadcrumbGroup from '../../../lib/components/breadcrumb-group'; | |||
|
|
|||
| export function renderComponent(jsx: React.ReactElement) { | |||
There was a problem hiding this comment.
jest/no-export rule in action
| const stickyNotificationsHeight = stickyNotifications ? notificationsHeight ?? 0 : 0; | ||
| const stickyNotificationsHeight = stickyNotifications ? (notificationsHeight ?? 0) : 0; |
There was a problem hiding this comment.
Prettier dependency got upgraded in this PR: 3.2.5 -> 3.5.3
| @@ -1,5 +1,7 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| /* eslint-disable jest/no-export */ | |||
There was a problem hiding this comment.
This rule fails to detect test helper files. We do not have too many, disabled manually for now
| @@ -278,7 +278,6 @@ export default function CollapsibleFlashbar({ items, ...restProps }: FlashbarPro | |||
| > | |||
| {showInnerContent(item) && ( | |||
| <Flash | |||
| // eslint-disable-next-line react/forbid-component-props | |||
There was a problem hiding this comment.
We do not have this rule enabled, react/forbid-component-props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade eslint to v9
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.