feat: Tabs scroll snapping #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 784 784
Lines 22130 22130
Branches 7528 7586 +58
=======================================
Hits 21335 21335
- Misses 743 788 +45
+ Partials 52 7 -45 ☔ View full report in Codecov by Sentry. |
…dth to make its center position to be aligned with a center of the container
georgylobko
requested review from
orangevolon and
gethinwebster
and removed request for
a team
jperals
reviewed
Dec 18, 2024
| @@ -223,13 +223,25 @@ test( | |||
| await page.setWindowSize({ width: 500, height: 1000 }); | |||
| await page.click('#add-tab'); | |||
| await page.click(page.paginationButton('right', true)); | |||
| await page.click(page.paginationButton('right', true)); | |||
There was a problem hiding this comment.
Why is it necessary to click once more in the right arrow now? Actually, it looks like the component scrolls a bit further now than before, making the seventh tab visible with one single click whereas before it wasn't.
There was a problem hiding this comment.
The component actually scrolls slightly less than before, which is why this condition is necessary
gethinwebster
approved these changes
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduced tabs scroll snapping reverted in this commit.
The main issue with the previous implementation was that the custom scrollIntoView could scroll in a way that pushed the active element out of view.
This PR adjusts the scrollIntoView logic to always center the active element in the container, which should fix the problem.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.