Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use selectionGroupLabel as an aria label for table header in… #3104

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

taheramr
Copy link
Member

@taheramr taheramr commented Dec 6, 2024

… selection mode

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (646fc45) to head (54abbc7).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3104   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         780      778    -2     
  Lines       21927    21933    +6     
  Branches     7512     7462   -50     
=======================================
+ Hits        21126    21133    +7     
+ Misses        749      748    -1     
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot removed their assignment Dec 9, 2024
@avinashbot avinashbot self-requested a review December 9, 2024 10:35
@taheramr taheramr marked this pull request as ready for review December 9, 2024 11:35
@taheramr taheramr requested a review from a team as a code owner December 9, 2024 11:35
@@ -94,6 +96,7 @@ export function TableThElement({
{...getTableColHeaderRoleProps({ tableRole, sortingStatus, colIndex })}
tabIndex={cellTabIndex === -1 ? undefined : cellTabIndex}
{...copyAnalyticsMetadataAttribute(props)}
{...(ariaLabel ? { 'aria-label': ariaLabel } : {})}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, optional: since undefined properties aren't applied and we don't expect empty strings, this can just be:

Suggested change
{...(ariaLabel ? { 'aria-label': ariaLabel } : {})}
aria-label={ariaLabel}

@taheramr taheramr added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 017cc34 Dec 10, 2024
38 checks passed
@taheramr taheramr deleted the chore/add-selection-aria-label-to-th branch December 10, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants