Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makes autosuggest input use aria-expanded every time the dropdown is shown #3099

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Dec 5, 2024

Description

Currently, the aria-expanded on autosuggest input is set to false when the dropdown has only entered text value option. That is inconsistent to states when the dropdown only shows a status like "finished" or "loading". The PR makes it so the ARIA expanded is added whenever the dropdown is visible.

Additionally, the PR refactors autosuggest dropdown states tests mainly to include the filtering results text feature that does not have a single in the main.

Rel: [A2f2AlIalxx9]

How has this been tested?

  • Updated unit tests to secure the aria-expanded is set to true for all dropdown states.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (a5be1f7) to head (4284824).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3099   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         778      778           
  Lines       21899    21902    +3     
  Branches     7514     7504   -10     
=======================================
+ Hits        21099    21102    +3     
  Misses        748      748           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot force-pushed the fix-autosuggest-consistent-aria-expanded branch from 6fad9fe to 4284824 Compare December 5, 2024 10:37
@pan-kot pan-kot marked this pull request as ready for review December 5, 2024 15:50
@pan-kot pan-kot requested a review from a team as a code owner December 5, 2024 15:50
@pan-kot pan-kot requested review from orangevolon and removed request for a team December 5, 2024 15:50
@pan-kot pan-kot added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 049115b Dec 17, 2024
40 checks passed
@pan-kot pan-kot deleted the fix-autosuggest-consistent-aria-expanded branch December 17, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants