Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update wizard's i18nStrings.submitButton description #3094

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Dec 3, 2024

Description

Updated wizard's i18nStrings.submitButton description to clarify that this value is not supported in Cloudscape's i18nProvider.

Related links, issue #, if available: AWSUI-60108

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner December 3, 2024 14:20
@cansuaa cansuaa requested review from pan-kot and removed request for a team December 3, 2024 14:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (d1ff27e) to head (2d285c9).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3094   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         779      779           
  Lines       21913    21913           
  Branches     7502     7502           
=======================================
  Hits        21112    21112           
  Misses        749      749           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansuaa cansuaa added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit f441384 Dec 16, 2024
38 checks passed
@cansuaa cansuaa deleted the cansua/wizard-i18n-api-description branch December 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants