Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Aug 28, 2024

Description

Introducing property filter token groups as an internal feature first.

Depends on cloudscape-design/collection-hooks#74

Rel: [qUFhApKfmWEg]

How has this been tested?

  • New unit tests
  • Manual testing
  • Bug bash
  • Screenshot tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner August 28, 2024 13:23
@pan-kot pan-kot requested review from gethinwebster and removed request for a team August 28, 2024 13:23
@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 99.17355% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (ca81699) to head (39961ee).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/property-filter/utils.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2627      +/-   ##
==========================================
- Coverage   95.81%   95.79%   -0.03%     
==========================================
  Files         743      743              
  Lines       20469    20525      +56     
  Branches     6595     6618      +23     
==========================================
+ Hits        19612    19661      +49     
- Misses        849      856       +7     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


&.token-editor-supports-groups {
padding-block-end: awsui.$space-m;
border-block-end: 1px solid awsui.$color-border-divider-default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better awsui.$border-divider-section-width than 1px?

return source.indexOf(target) === 0;
}

interface AbstractToken {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these Abstract* interfaces needed rather than using e.g. InternalToken directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The utility is used also on Token type when converting groups to tokens if enableTokenGroups=false:

if (enableTokenGroups) {
  fireNonCancelableEvent(onChange, { tokens: [], operation: query.operation, tokenGroups: tokens });
} else {
  fireNonCancelableEvent(onChange, { tokens: tokenGroupToTokens<Token>(tokens), operation: query.operation });
}

@pan-kot pan-kot added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 09aa16f Sep 4, 2024
@pan-kot pan-kot deleted the pfg-phase-1-internal branch September 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants