-
Notifications
You must be signed in to change notification settings - Fork 204
chore: Property filter token groups internal feature #2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
==========================================
- Coverage 95.81% 95.79% -0.03%
==========================================
Files 743 743
Lines 20469 20525 +56
Branches 6595 6618 +23
==========================================
+ Hits 19612 19661 +49
- Misses 849 856 +7
Partials 8 8 ☔ View full report in Codecov by Sentry. |
d70f5eb to
5334390
Compare
c29caca to
4a8347b
Compare
4a8347b to
f740eeb
Compare
src/property-filter/styles.scss
Outdated
|
|
||
| &.token-editor-supports-groups { | ||
| padding-block-end: awsui.$space-m; | ||
| border-block-end: 1px solid awsui.$color-border-divider-default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps better awsui.$border-divider-section-width than 1px?
| return source.indexOf(target) === 0; | ||
| } | ||
|
|
||
| interface AbstractToken { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these Abstract* interfaces needed rather than using e.g. InternalToken directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The utility is used also on Token type when converting groups to tokens if enableTokenGroups=false:
if (enableTokenGroups) {
fireNonCancelableEvent(onChange, { tokens: [], operation: query.operation, tokenGroups: tokens });
} else {
fireNonCancelableEvent(onChange, { tokens: tokenGroupToTokens<Token>(tokens), operation: query.operation });
}
Description
Introducing property filter token groups as an internal feature first.
Depends on cloudscape-design/collection-hooks#74
Rel: [qUFhApKfmWEg]
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.