Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disabled reason for Button and ButtonDropdown #2409

Merged
merged 31 commits into from
Jul 10, 2024
Merged

feat: Disabled reason for Button and ButtonDropdown #2409

merged 31 commits into from
Jul 10, 2024

Commits on Jun 25, 2024

  1. Move use-hidden-description from src/button-dropdown/utils to src/int… 

    …ernal/hooks
    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1e7f214 View commit details
    Browse the repository at this point in the history

  2. Add className prop to internal tooltip

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a6f404d View commit details
    Browse the repository at this point in the history

  3. Add disabledReason prop to Button

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1246781 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cbb4e3c View commit details
    Browse the repository at this point in the history

  5. Add u tests for disabledReason button for onMouseEnter and onMouseLea… 

    …ve behavior
    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    47d08ac View commit details
    Browse the repository at this point in the history

  6. Add disabledReason prop to ButtonDropdown

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8c7e2e7 View commit details
    Browse the repository at this point in the history

  7. Replace undefined with empty string as values for disabledReason on b… 

    …utton-dropdown permutation page
    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    351138b View commit details
    Browse the repository at this point in the history

  8. Fix key uniqueness issue on button-dropdown permutations page

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ae512f0 View commit details
    Browse the repository at this point in the history

  9. Introduce tokens $color-text-button-normal-disabled $color-text-butto… 

    …n-primary-disabled for color in disabled state in normal and primary buttons
    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5004ab6 View commit details
    Browse the repository at this point in the history

  10. Fix tooltip import

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8933061 View commit details
    Browse the repository at this point in the history

  11. Add disabled reason page for button component

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e3e9653 View commit details
    Browse the repository at this point in the history

  12. Remove disabled reason from button permutation page

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6e1a6ae View commit details
    Browse the repository at this point in the history

  13. Add disabled reason examples for button-dropdown

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d867c86 View commit details
    Browse the repository at this point in the history

  14. Fix a11y issues in button/button-dropdown pages

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    edde864 View commit details
    Browse the repository at this point in the history

  15. Fix: prevent triggering event on disabled link button

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    347c1db View commit details
    Browse the repository at this point in the history

  16. Update snapshots

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6f579d7 View commit details
    Browse the repository at this point in the history

  17. Fix: remove unnecessary import in tooltip component

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d1c27e7 View commit details
    Browse the repository at this point in the history

  18. Fix: remove findDisabledReasonDescription test util method

    @georgylobko
    georgylobko committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    53806aa View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. fix: Make findDisabledReason test-util method access portal tooltip v… 

    …ia global document root
    @georgylobko
    georgylobko committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ebd08a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix: Address code review comments

    @georgylobko
    georgylobko committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b67385f View commit details
    Browse the repository at this point in the history

  2. chore: Add test to check if onClick handler is not triggered when dis… 

    …abled with reason
    @georgylobko
    georgylobko committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    051324c View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' into feat/disabled-reason-buttons

    @georgylobko
    georgylobko authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b7b34a9 View commit details
    Browse the repository at this point in the history

  2. fix: Import button test classes in test-utils

    @georgylobko
    georgylobko committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    abdf549 View commit details
    Browse the repository at this point in the history

  3. chore: Update test snapshots

    @georgylobko
    georgylobko committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    52595bc View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. chore: Change colorBackgroundButtonPrimaryDisabled value

    @georgylobko
    georgylobko committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3fbbd6a View commit details
    Browse the repository at this point in the history

  2. chore: Update test snapshots

    @georgylobko
    georgylobko committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    067e1a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. fix: Remove redundant button-dropdown example

    @georgylobko
    georgylobko committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    77576c7 View commit details
    Browse the repository at this point in the history

  2. fix: Update snapshots

    @georgylobko
    georgylobko committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8368333 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. chore: Make disabledReason prop applicable only for normal and primar… 

    …y variants
    @georgylobko
    georgylobko committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b675692 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/disabled-reason-buttons

    @georgylobko
    georgylobko authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d0255d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. fix: Change the condition that sets the button's disabled attribute f… 

    …or all variants but primary and normal
    @georgylobko
    georgylobko committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bd77af9 View commit details
    Browse the repository at this point in the history