ci: run sweepers before/after tests and fix deletion order - #154
Open
urscale wants to merge 2 commits into
Open
Conversation
mweibel
reviewed
Aug 24, 2026
Floating IPs can also be attached to loadbalancers Co-authored-by: Michael Weibel <307427+mweibel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance-test suite sometimes leaves cloud resources behind
(e.g. servers, routers, volumes) when a run timed out or was cancelled.
Subsequent runs then fail because the orphaned resources hit limits
or blocked creation of new dependencies.
Changes:
always()) so leaks from the current runare removed even if the tests fail or timeout.
SweeperDependenciesso Terraform destroys in thecorrect order: servers before floating IPs, volumes, server groups,
load balancers, and custom images; routers before networks.
This mirrors the Makefile
sweeptarget that already existed but wasnever invoked in CI.