Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 阿里云的 golang SDK 会把整个 object KEY也编码 #694

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

ihipop
Copy link
Contributor

@ihipop ihipop commented Dec 25, 2020

(cherry picked from commit b9cd82b)

Fix #677

@HFO4
Copy link
Member

HFO4 commented Mar 17, 2021

感谢PR,不影响核心可用性的话,还是先不要单独修复了,等待 OSS 上游 SDK 修复吧

@HFO4 HFO4 closed this Mar 17, 2021
@ihipop
Copy link
Contributor Author

ihipop commented Mar 17, 2021

感谢PR,不影响核心可用性的话,还是先不要单独修复了,等待 OSS 上游 SDK 修复吧

上游不会修了 这是上游故意的,我翻了提交记录, 当他们认为 / 必须编码的时候 这是一种阿里的价值观 你很难说服他们了 aliyun/aliyun-oss-go-sdk#212

而golang在path已经编码的情况下不会自己去重复编码的,除非和我的fix那样清空已经有的编码的结果,然后golang会用正确的行为重新编码。

@HFO4 HFO4 reopened this Mar 17, 2021
@HFO4 HFO4 merged commit 270f617 into cloudreve:master Mar 17, 2021
@HFO4
Copy link
Member

HFO4 commented Mar 17, 2021

感谢PR,不影响核心可用性的话,还是先不要单独修复了,等待 OSS 上游 SDK 修复吧

上游不会修了 这是上游故意的,我翻了提交记录, 当他们认为 / 必须编码的时候 这是一种阿里的价值观 你很难说服他们了 aliyun/aliyun-oss-go-sdk#212

而golang在path已经编码的情况下不会自己去重复编码的,除非和我的fix那样清空已经有的编码的结果,然后golang会用正确的行为重新编码。

OK,感谢,已经合并

HFO4 added a commit that referenced this pull request Mar 22, 2021
@HFO4
Copy link
Member

HFO4 commented Mar 22, 2021

这个修复会引发副作用,文件名中的 + 之类的字符会导致签名不匹配(#802),暂时先 revert 了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

外链(直链)为什么要对 / 进行URL编码
2 participants