Merge pull request #1690 from cloudreve/webdav-checksum

webdav兼容rclone的nextcloud选项(修改日期和checksum)
cloudreve · Apr 8, 2023 · ce579d3 · ce579d3
2 parents 98788dc + f1e7af6
commit ce579d3
Show file tree

Hide file tree

Showing 5 changed files with 103 additions and 13 deletions.
diff --git a/models/file.go b/models/file.go
@@ -44,6 +44,8 @@ const (
 
 	ThumbStatusMetadataKey  = "thumb_status"
 	ThumbSidecarMetadataKey = "thumb_sidecar"
+
+	ChecksumMetadataKey = "webdav_checksum"
 )
 
 func init() {

diff --git a/pkg/filesystem/hooks.go b/pkg/filesystem/hooks.go
@@ -10,7 +10,10 @@ import (
 	"github.com/cloudreve/Cloudreve/v3/pkg/serializer"
 	"github.com/cloudreve/Cloudreve/v3/pkg/util"
 	"io/ioutil"
+	"net/http"
+	"strconv"
 	"strings"
+	"time"
 )
 
 // Hook 钩子函数
@@ -268,3 +271,34 @@ func HookDeleteUploadSession(id string) Hook {
 		return nil
 	}
 }
+
+// NewWebdavAfterUploadHook 每次创建一个新的钩子函数 rclone 在 PUT 请求里有 OC-Checksum 字符串
+// 和 X-OC-Mtime
+func NewWebdavAfterUploadHook(request *http.Request) func(ctx context.Context, fs *FileSystem, newFile fsctx.FileHeader) error {
+	var modtime time.Time
+	if timeVal := request.Header.Get("X-OC-Mtime"); timeVal != "" {
+		timeUnix, err := strconv.ParseInt(timeVal, 10, 64)
+		if err == nil {
+			modtime = time.Unix(timeUnix, 0)
+		}
+	}
+	checksum := request.Header.Get("OC-Checksum")
+
+	return func(ctx context.Context, fs *FileSystem, newFile fsctx.FileHeader) error {
+		file := newFile.Info().Model.(*model.File)
+		if !modtime.IsZero() {
+			err := model.DB.Model(file).UpdateColumn("updated_at", modtime).Error
+			if err != nil {
+				return err
+			}
+		}
+
+		if checksum != "" {
+			return file.UpdateMetadata(map[string]string{
+				model.ChecksumMetadataKey: checksum,
+			})
+		}
+
+		return nil
+	}
+}
diff --git a/pkg/webdav/file.go b/pkg/webdav/file.go
@@ -44,6 +44,7 @@ func moveFiles(ctx context.Context, fs *filesystem.FileSystem, src FileInfo, dst
 		}
 	}
 
+
 	// 判断是否需要移动
 	if src.GetPosition() != path.Dir(dst) {
 		err = fs.Move(
@@ -80,27 +81,33 @@ func copyFiles(ctx context.Context, fs *filesystem.FileSystem, src FileInfo, dst
 	}
 	recursion++
 
+
+	var (
+		fileIDs   []uint
+		folderIDs []uint
+	)
+
 	if overwrite {
 		if err := _checkOverwriteFile(ctx, fs, src, dst); err != nil {
 			return http.StatusInternalServerError, err
 		}
 	}
 
 	if src.IsDir() {
-		err := fs.Copy(
-			ctx,
-			[]uint{src.(*model.Folder).ID},
-			[]uint{}, src.(*model.Folder).Position,
-			path.Dir(dst),
-		)
-		if err != nil {
-			return http.StatusInternalServerError, err
-		}
+		folderIDs = []uint{src.(*model.Folder).ID}
 	} else {
-		err := fs.Copy(ctx, []uint{}, []uint{src.(*model.File).ID}, src.(*model.File).Position, path.Dir(dst))
-		if err != nil {
-			return http.StatusInternalServerError, err
-		}
+		fileIDs = []uint{src.(*model.File).ID}
+	}
+
+	err = fs.Copy(
+		ctx,
+		folderIDs,
+		fileIDs,
+		src.GetPosition(),
+		path.Dir(dst),
+	)
+	if err != nil {
+		return http.StatusInternalServerError, err
 	}
 
 	return http.StatusNoContent, nil

diff --git a/pkg/webdav/prop.go b/pkg/webdav/prop.go
@@ -16,9 +16,30 @@ import (
 	"strconv"
 	"time"
 
+	model "github.com/cloudreve/Cloudreve/v3/models"
 	"github.com/cloudreve/Cloudreve/v3/pkg/filesystem"
 )
 
+type FileDeadProps struct {
+	*model.File
+}
+
+// 实现 webdav.DeadPropsHolder 接口，不能在models.file里面定义
+func (file *FileDeadProps) DeadProps() (map[xml.Name]Property, error) {
+	return map[xml.Name]Property{
+		xml.Name{Space: "http://owncloud.org/ns", Local: "checksums"}: {
+			XMLName: xml.Name{
+				Space: "http://owncloud.org/ns", Local: "checksums",
+			},
+			InnerXML: []byte("<checksum>" + file.MetadataSerialized[model.ChecksumMetadataKey] + "</checksum>"),
+		},
+	}, nil
+}
+
+func (file *FileDeadProps) Patch([]Proppatch) ([]Propstat, error) {
+	return nil, nil
+}
+
 type FileInfo interface {
 	GetSize() uint64
 	GetName() string
@@ -177,8 +198,18 @@ var liveProps = map[xml.Name]struct {
 // of one Propstat element.
 func props(ctx context.Context, fs *filesystem.FileSystem, ls LockSystem, fi FileInfo, pnames []xml.Name) ([]Propstat, error) {
 	isDir := fi.IsDir()
+	if !isDir {
+		fi = &FileDeadProps{fi.(*model.File)}
+	}
 
 	var deadProps map[xml.Name]Property
+	if dph, ok := fi.(DeadPropsHolder); ok {
+		var err error
+		deadProps, err = dph.DeadProps()
+		if err != nil {
+			return nil, err
+		}
+	}
 
 	pstatOK := Propstat{Status: http.StatusOK}
 	pstatNotFound := Propstat{Status: http.StatusNotFound}
@@ -210,15 +241,28 @@ func props(ctx context.Context, fs *filesystem.FileSystem, ls LockSystem, fi Fil
 // Propnames returns the property names defined for resource name.
 func propnames(ctx context.Context, fs *filesystem.FileSystem, ls LockSystem, fi FileInfo) ([]xml.Name, error) {
 	isDir := fi.IsDir()
+	if !isDir {
+		fi = &FileDeadProps{fi.(*model.File)}
+	}
 
 	var deadProps map[xml.Name]Property
+	if dph, ok := fi.(DeadPropsHolder); ok {
+		var err error
+		deadProps, err = dph.DeadProps()
+		if err != nil {
+			return nil, err
+		}
+	}
 
 	pnames := make([]xml.Name, 0, len(liveProps)+len(deadProps))
 	for pn, prop := range liveProps {
 		if prop.findFn != nil && (prop.dir || !isDir) {
 			pnames = append(pnames, pn)
 		}
 	}
+	for pn := range deadProps {
+		pnames = append(pnames, pn)
+	}
 	return pnames, nil
 }
 

diff --git a/pkg/webdav/webdav.go b/pkg/webdav/webdav.go
@@ -389,6 +389,9 @@ func (h *Handler) handlePut(w http.ResponseWriter, r *http.Request, fs *filesyst
 		fs.Use("AfterValidateFailed", filesystem.HookDeleteTempFile)
 	}
 
+	// rclone 请求
+	fs.Use("AfterUpload", filesystem.NewWebdavAfterUploadHook(r))
+
 	// 执行上传
 	err = fs.Upload(ctx, &fileData)
 	if err != nil {