Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sync sharding options #401

Closed
wants to merge 1 commit into from
Closed

feat: Add sync sharding options #401

wants to merge 1 commit into from

Conversation

erezrokah
Copy link
Member

@erezrokah erezrokah commented Sep 11, 2024

Summary

Goes with cloudquery/plugin-pb#26

Still testing this so in draft


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt ./... to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@erezrokah erezrokah marked this pull request as ready for review September 17, 2024 16:07
@erezrokah erezrokah requested a review from a team as a code owner September 17, 2024 16:07
@erezrokah erezrokah requested review from marianogappa and removed request for a team September 17, 2024 16:07
@github-actions github-actions bot added feat and removed feat labels Sep 17, 2024
@erezrokah
Copy link
Member Author

Once cloudquery/plugin-pb#26 is merged this PR will get autogenerated so we will be able to close this one

@erezrokah
Copy link
Member Author

Done in #407

@erezrokah erezrokah closed this Sep 17, 2024
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Sep 18, 2024
#### Summary

Goes with cloudquery/plugin-pb-go#401. ~~Still testing this so in draft~~

Part of cloudquery/cloudquery-issues#2214 (internal issue)

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant