Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add more govet lint rules #383

Merged
merged 2 commits into from
Aug 2, 2024
Merged

chore: Add more govet lint rules #383

merged 2 commits into from
Aug 2, 2024

Conversation

erezrokah
Copy link
Member

Summary

Similar to cloudquery/plugin-sdk#1849

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt ./... to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested a review from a team as a code owner August 2, 2024 10:13
@erezrokah erezrokah requested review from marianogappa and removed request for a team August 2, 2024 10:13
@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Aug 2, 2024
@kodiakhq kodiakhq bot merged commit 29f668b into main Aug 2, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the chore/better_linting branch August 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianogappa marianogappa marianogappa approved these changes

Assignees
No one assigned
Labels
automerge Add to automerge PRs once requirements are met ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @marianogappa