feat: Allow use of CloudQuery registry with docker plugins #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
erezrokah
and removed request for
yevgenypats
erezrokah
approved these changes
Feb 2, 2024
disq
reviewed
Feb 2, 2024
| if p.JSON200 == nil { | ||
| return false, fmt.Errorf("failed to get plugin information: response body is empty") | ||
| } | ||
| return p.JSON200.PackageType == "docker", nil |
There was a problem hiding this comment.
Suggested change
| return p.JSON200.PackageType == "docker", nil | |
| return p.JSON200.PackageType == cloudquery_api.PluginVersionPackageTypeDocker, nil |
Might need a string()
disq
approved these changes
Feb 2, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.17.0](v1.16.8...v1.17.0) (2024-02-05) ### Features * Allow use of CloudQuery registry with docker plugins ([#235](#235)) ([58ec077](58ec077)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.7.3 ([#237](#237)) ([e7a6085](e7a6085)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Docker plugins to use the CloudQuery registry, meaning that configs can now be written like:
instead of
The
dockerregistry can still be used if preferred, either with or without thedocker.cloudquery.iopath.