Skip to content

Commit

Permalink
fix: Create docker container with Tty true (#87)
Browse files Browse the repository at this point in the history

Fixes #86

See logs https://pkg.go.dev/github.com/docker/docker@v20.10.25+incompatible/client#Client.ContainerLogs

This means we'll only read `stdout` from the container (I think that's OK). If we want `stderr` we'll need to demultiplex the steam, see 
![image](https://github.com/cloudquery/plugin-pb-go/assets/26760571/1d74a864-bcba-4fd6-ade2-dacf4508a7ea)


---
  • Loading branch information
erezrokah authored Aug 17, 2023
1 parent 7e5b368 commit 4c70f9a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions managedplugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ func (c *Client) startDockerPlugin(ctx context.Context, configPath string) error
},
Image: configPath,
Cmd: pluginArgs,
Tty: true,
}
hostConfig := &container.HostConfig{
PortBindings: map[nat.Port][]nat.PortBinding{
Expand Down

0 comments on commit 4c70f9a

Please sign in to comment.