Skip to content

Fix example code #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2018
Merged

Fix example code #9

merged 1 commit into from
Aug 10, 2018

Conversation

SevereOverfl0w
Copy link
Contributor

I didn't have gomplate installed, so I couldn't regenerate the readme

sarkis
sarkis previously approved these changes Aug 9, 2018
View reviewed changes
aknysh
aknysh previously approved these changes Aug 9, 2018
View reviewed changes
@aknysh
Copy link
Member

aknysh commented Aug 9, 2018

@SevereOverfl0w
thank you for the fix.
you can regenerate README by executing these commands:

make init
make readme/deps
make readme

let us know if you can do it, otherwise we'll regenerate it.
thanks

@SevereOverfl0w SevereOverfl0w dismissed stale reviews from aknysh and sarkis via f23ffa4 August 10, 2018 05:41
@SevereOverfl0w
Copy link
Contributor Author

Thank you, the readme/deps was the missing piece of the puzzle. Regenerated and pushed.

@aknysh aknysh merged commit 3465ab9 into cloudposse:master Aug 10, 2018
@aknysh
Copy link
Member

aknysh commented Aug 10, 2018

thanks @SevereOverfl0w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

+1 more reviewer

@sarkis sarkis sarkis left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SevereOverfl0w @aknysh @sarkis