Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support AWS provider v4 #11

Merged
merged 11 commits into from
Mar 28, 2022
Merged

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Mar 15, 2022

what

  • Upgrade to support AWS provider v4
  • Upgrade to latest s3 bucket module

why

  • This module is currently unusable in projects using AWS provider v4

references

@woz5999 woz5999 requested review from a team as code owners March 15, 2022 23:24
@woz5999 woz5999 requested review from florian0410 and SweetOps and removed request for a team March 15, 2022 23:24
@woz5999 woz5999 requested a review from a team as a code owner March 15, 2022 23:25
@korenyoni
Copy link
Member

/test all

Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing — has to do with the Terraform version constraint in examples/complete https://github.com/cloudposse/actions/runs/5570481170?check_suite_focus=true

@woz5999
Copy link
Contributor Author

woz5999 commented Mar 16, 2022

/test all

@woz5999 woz5999 requested a review from korenyoni March 16, 2022 17:54
@mergify mergify bot dismissed korenyoni’s stale review March 16, 2022 18:29

This Pull Request has been updated, so we're dismissing all reviews.

@Nuru
Copy link

Nuru commented Mar 16, 2022

/test all

@woz5999
Copy link
Contributor Author

woz5999 commented Mar 21, 2022

/test all

@woz5999 woz5999 requested a review from Nuru March 25, 2022 00:51
@woz5999 woz5999 merged commit 9f718ff into cloudposse:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants